Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CDE-344]: Skip CDE VMs in the dlite instance purger with the help of labels on the instance/VM #506

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

vikyathharekal
Copy link
Collaborator

  1. Storing labels in the instance table as well as setting them in the VM in the ignite run command
  2. Added migration to add this column with default {"retain":"false"}
  3. CI instances/VMs will have {"retain":"false"} label
  4. CDE instances/VMs will have {"retain":"false"} label
  5. The list instance query from the purger would have {"retain":"false"} matchlabels to match only CI instances and avoid cleanup of CDE instances/VMs

Commit Checklist

Thank you for creating a pull request! To help us review / merge this can you make sure that your PR adheres as much as possible to the following.

The Basics

If you are adding new functionality, please provide evidence of the new functionality.

@vikyathharekal vikyathharekal merged commit ca86ea7 into master Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants